Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inheritdoc bugs for full or partial inheritance #130

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Fix inheritdoc bugs for full or partial inheritance #130

merged 2 commits into from
Sep 9, 2022

Conversation

carlossanlop
Copy link
Member

  • Avoid escaping crefs except when printing to log.
  • Make sure params and typeparams are also ported when inheriting from base type or interface.
  • Add tests.

Future TODO: Implement functionality for -PreserveInheritDocTag false and add tests: #129

@carlossanlop
Fix inheritdoc bugs for full or partial inheritance:
9566fe0 
- Avoid escaping crefs except when printing to log.
- Make sure params and typeparams are also ported when inheriting from base type or interface.
- Add tests.
@carlossanlop carlossanlop added the port-to-docs Issues related to the PortToDocs tool. label Sep 9, 2022
@carlossanlop carlossanlop mentioned this pull request Sep 9, 2022
Open
@carlossanlop carlossanlop merged commit 1dd98ad into dotnet:main Sep 9, 2022
@carlossanlop carlossanlop deleted the FixInheritDocBugs branch September 9, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
port-to-docs Issues related to the PortToDocs tool.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@carlossanlop